Modify scavenger GC count #22180
Merged
Modify scavenger GC count #22180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amicic These are the changes in openj9. |
|
This PR needs eclipse-omr/omr#7814 |
amicic
reviewed
Jul 3, 2025
runtime/gc_trace/TgcParallel.cpp
Outdated
| @@ -259,15 +259,15 @@ tgcHookLocalGcEnd(J9HookInterface** hook, uintptr_t eventNum, void* eventData, v | |||
| tgcExtensions->printf(" (micros) (micros) freelist freelist scanlist scanlist lock arrays arraysize copycache lists deep objs list\n"); | |||
|
|
|||
| scavengeTotalTime = event->incrementEndTime - event->incrementStartTime; | |||
| uintptr_t gcCount = extensions->scavengerStats._gcCount; | |||
| uintptr_t gcCount = extensions->incrementScavengerStats._gcCount; | |||
There was a problem hiding this comment.
minor but let's call the local: gcIncrementCount, and thnt use it later when doing the participation check
There was a problem hiding this comment.
I replaced it with j9gc_get_unique_GC_count. I think that's what you meant?
amicic
reviewed
Jul 3, 2025
runtime/gc_trace/TgcDump.cpp
Outdated
| @@ -61,7 +61,7 @@ tgcHookGlobalGcSweepEnd(J9HookInterface** hook, UDATA eventNum, void* eventData, | |||
| gcCount = extensions->globalGCStats.gcCount; | |||
| if (extensions->isStandardGC()) { | |||
| #if defined(J9VM_GC_MODRON_SCAVENGER) | |||
| gcCount += extensions->scavengerStats._gcCount; | |||
| gcCount += extensions->incrementScavengerStats._gcCount; | |||
There was a problem hiding this comment.
we probably want to be consistent with JFR counting (hence base it on cycle).
for the whole block, we should probably even just call j9gc_get_unique_GC_count
There was a problem hiding this comment.
Replaced with unique gc count.
adpopescu
force-pushed
the
jfr-gc-events
branch
4 times, most recently
from
1af8016 to
c927901
Compare
|
Oh wait. I should add in a change to use the omr function in gc_get_unique before you run any tests. Ok I added it in. |
This change aligns openj9 usage of incrementScavengerStats to be consistent with a recent change in omr. Signed-off-by: Adrian Popescu <[email protected]>
amicic
approved these changes
Jul 10, 2025
|
jenkins test sanity amac jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns openj9 usage of incrementScavengerStats to be consistent with a recent change in omr.