Skip to content

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Aug 15, 2025

Which problem is this PR solving?

Description of the changes

  • Add upload pr_number artifacts action
  • The ci-comment.yml workflow can now detect pr number by downloading the artifact

How was this change tested?

Successfully extracted metrics_snapshot_elasticsearch_8.x_v2
Processing artifact: diff_metrics_snapshot_elasticsearch_8.x_v2 (ID: 3776313824)
Extracting to /home/runner/work/jaeger/jaeger/.metrics/diff_metrics_snapshot_elasticsearch_8.x_v2
Successfully extracted diff_metrics_snapshot_elasticsearch_8.x_v2

Starting PR number detection...
Workflow run details:
- Head branch: error_branch
- Head repository: pipiland2612/jaeger
- Commit SHA: 49af2ee184cc536901005ca2af043cb32ad1e493

Attempt 1: Searching PRs for branch pipiland2612/jaeger:error_branch
Found PR Number from artifact: 2

Final PR Number: 2

Checklist

Signed-off-by: pipiland2612 <[email protected]>
@pipiland2612 pipiland2612 requested a review from a team as a code owner August 15, 2025 19:04
@pipiland2612
Copy link
Contributor Author

Hi @yurishkuro, I think this could solve our CI error: Could not determine PR number for commenting. I have tested in my own forked and it's good. Hope we can finish this soon!

@pipiland2612 pipiland2612 changed the title Add upload pr_number artifacts action [CI] Add upload pr_number artifacts action to ci-e2e-all.yml Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.63%. Comparing base (97f40a9) to head (95d0b38).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7448   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         377      377           
  Lines       23089    23089           
=======================================
  Hits        22312    22312           
  Misses        592      592           
  Partials      185      185           
Flag Coverage Δ
badger_v1 9.02% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1-manual 11.68% <ø> (ø)
cassandra-4.x-v2-auto 1.69% <ø> (ø)
cassandra-4.x-v2-manual 1.69% <ø> (ø)
cassandra-5.x-v1-manual 11.68% <ø> (ø)
cassandra-5.x-v2-auto 1.69% <ø> (ø)
cassandra-5.x-v2-manual 1.69% <ø> (ø)
elasticsearch-6.x-v1 16.58% <ø> (ø)
elasticsearch-7.x-v1 16.62% <ø> (ø)
elasticsearch-8.x-v1 16.77% <ø> (ø)
elasticsearch-8.x-v2 1.70% <ø> (ø)
elasticsearch-9.x-v2 1.70% <ø> (ø)
grpc_v1 10.22% <ø> (ø)
grpc_v2 1.70% <ø> (ø)
kafka-3.x-v1 9.67% <ø> (ø)
kafka-3.x-v2 1.70% <ø> (ø)
memory_v2 1.70% <ø> (ø)
opensearch-1.x-v1 16.67% <ø> (ø)
opensearch-2.x-v1 16.67% <ø> (ø)
opensearch-2.x-v2 1.70% <ø> (ø)
opensearch-3.x-v2 1.70% <ø> (ø)
query 1.70% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pipiland2612
Copy link
Contributor Author

When this is merged, I think we can rerun the CI in the testing pr

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Aug 15, 2025
@yurishkuro yurishkuro merged commit 62a12a8 into jaegertracing:main Aug 15, 2025
64 of 65 checks passed
@pipiland2612 pipiland2612 deleted the Fix_workflow branch August 16, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants