[CI] Add new post comment workflow #7414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7414 +/- ##
==========================================
+ Coverage 96.44% 96.64% +0.20%
==========================================
Files 377 377
Lines 23092 23089 -3
==========================================
+ Hits 22271 22315 +44
+ Misses 622 590 -32
+ Partials 199 184 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
internal/storage/v1/api/spanstore/spanstoremetrics/read_metrics.go
Outdated
Show resolved
Hide resolved
pipiland2612
commented
Aug 1, 2025
pipiland2612
changed the title
yurishkuro
reviewed
Aug 1, 2025
internal/storage/v1/api/spanstore/spanstoremetrics/read_metrics.go
Outdated
Show resolved
Hide resolved
|
Hi @yurishkuro, sorry. I got something to do this week, so I may continue the current work next week. Thanks! |
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
Signed-off-by: pipiland2612 <[email protected]>
pipiland2612
force-pushed
the
post_pr_comment
branch
from
b45066f to
883ad26
Compare
|
Hi @yurishkuro, I have tested this and it works in my forked repositiry pr: pipiland2612#1 (comment) |
yurishkuro
added
the
changelog:ci
yurishkuro
approved these changes
Aug 14, 2025
|
I'm refactoring the script into another file, waiting if it's working |
|
Let's test with a bogus pr now |
This was referenced Aug 14, 2025
yurishkuro
pushed a commit
that referenced
this pull request
Aug 15, 2025
## Which problem is this PR solving? - Resolves part of #6278 - Supports #7414 ## Description of the changes - Add upload pr_number artifacts action - The ci-comment.yml workflow can now detect pr number by downloading the artifact ## How was this change tested? - from my repostory pull request: pipiland2612#2 - log from the action https://github.com/pipiland2612/jaeger/actions/runs/16997159461/job/48190513998: ``` Successfully extracted metrics_snapshot_elasticsearch_8.x_v2 Processing artifact: diff_metrics_snapshot_elasticsearch_8.x_v2 (ID: 3776313824) Extracting to /home/runner/work/jaeger/jaeger/.metrics/diff_metrics_snapshot_elasticsearch_8.x_v2 Successfully extracted diff_metrics_snapshot_elasticsearch_8.x_v2 Starting PR number detection... Workflow run details: - Head branch: error_branch - Head repository: pipiland2612/jaeger - Commit SHA: 49af2ee Attempt 1: Searching PRs for branch pipiland2612/jaeger:error_branch Found PR Number from artifact: 2 Final PR Number: 2 ``` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland2612 <[email protected]>
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Aug 17, 2025
## Which problem is this PR solving? - Improves on #7414 - Resolves part of #6278 ## Description of the changes - Improve the readme file for better comment ## How was this change tested? - My own forked comment: pipiland2612#3 (comment) <img width="933" height="292" alt="Screenshot 2025-08-16 at 20 25 53" src="https://github.com/user-attachments/assets/7003746f-418a-4aca-8577-2dfc8f0e1dc8" /> <img width="948" height="852" alt="Screenshot 2025-08-16 at 20 26 06" src="https://github.com/user-attachments/assets/6b00369e-b76e-4e89-9f27-1b9a3be0ee54" /> ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland2612 <[email protected]>
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Aug 17, 2025
## Which problem is this PR solving? - Improves on #7414 - Resolves part of #6278 ## Description of the changes - Improve CI comment ## How was this change tested? - My own forked pr comment: pipiland2612#3 (comment) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland2612 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test