test: make overwrite confirmations deterministic#10274
Merged
dmadisetti merged 1 commit intoJul 22, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Architecture diagram
sequenceDiagram
participant Test as Test Function
participant CliRunner as CliRunner
participant main as marimo._cli.cli.main
participant utils as marimo._cli.utils
participant FS as File System
Note over Test,FS: Deterministic overwrite test (CliRunner)
Test->>utils: mock.patch('marimo._cli.utils.stdout')
Test->>utils: mock_stdout.isatty.return_value = True
Test->>CliRunner: invoke(main, args, input="y\n")
activate CliRunner
CliRunner->>main: run CLI command with stdin="y\n"
activate main
main->>utils: check stdout.isatty()
utils-->>main: True (mocked)
main->>main: prompt "Overwrite?"
main->>CliRunner: read stdin (simulated)
CliRunner-->>main: "y"
main->>FS: overwrite output file
FS-->>main: OK
main-->>CliRunner: exit code 0
deactivate main
CliRunner-->>Test: result
deactivate CliRunner
Test->>Test: assert result.exit_code == 0
Test->>Test: assert "Overwrite?" in result.output
Test->>FS: read output file
FS-->>Test: file contents
Test->>Test: assert expected content
mscolnick
approved these changes
Jul 22, 2026
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces timing-sensitive overwrite confirmation subprocesses with deterministic CliRunner tests that exercise the prompt and verify rewritten output.
Addresses marimo-team/ci-agent#74.