Skip to content

test: make overwrite confirmations deterministic #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmadisetti merged 1 commit into from
Jul 22, 2026
+34 −47
Merged

test: make overwrite confirmations deterministic #10274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 34 additions & 47 deletions tests/_cli/test_file_overwrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
import tempfile
from pathlib import Path
from typing import TYPE_CHECKING
from unittest import mock

import pytest
from click.testing import CliRunner

from marimo._cli.cli import main

if TYPE_CHECKING:
from collections.abc import Generator
Expand All @@ -31,31 +35,23 @@ def test_export_overwrite_confirm(
temp_marimo_file: str, existing_file: str
) -> None:
"""Test export command with file overwrite confirmation (user confirms)."""
p = subprocess.Popen(
[
"marimo",
"export",
"html",
temp_marimo_file,
"--output",
existing_file,
],
stdin=subprocess.PIPE,
)

assert p.poll() is None
assert p.stdin is not None

# Simulate user confirming overwrite
p.stdin.write(b"y\n")
p.stdin.flush()

# Wait for process to complete
p.wait(timeout=5)
with mock.patch("marimo._cli.utils.stdout") as mock_stdout:
mock_stdout.isatty.return_value = True
result = CliRunner().invoke(
main,
[
"export",
"html",
temp_marimo_file,
"--output",
existing_file,
],
input="y\n",
)

# Check that the file was overwritten
assert os.path.exists(existing_file)
assert p.returncode == 0
assert result.exit_code == 0, result.output
assert "Overwrite?" in result.output
assert "<!DOCTYPE html>" in Path(existing_file).read_text()


def test_export_overwrite_with_yes_flag() -> None:
Expand Down Expand Up @@ -176,30 +172,21 @@ def test_convert_overwrite_confirm(tmp_path: Path) -> None:
output_path = tmp_path / "output.py"
output_path.write_text("existing content")

p = subprocess.Popen(
[
"marimo",
"convert",
str(notebook_path),
"-o",
str(output_path),
],
stdin=subprocess.PIPE,
)

assert p.poll() is None
assert p.stdin is not None

# Simulate user confirming overwrite
p.stdin.write(b"y\n")
p.stdin.flush()

# Wait for process to complete
p.wait(timeout=5)
with mock.patch("marimo._cli.utils.stdout") as mock_stdout:
mock_stdout.isatty.return_value = True
result = CliRunner().invoke(
main,
[
"convert",
str(notebook_path),
"-o",
str(output_path),
],
input="y\n",
)

# Check that the file was overwritten
assert output_path.exists()
assert p.returncode == 0
assert result.exit_code == 0, result.output
assert "Overwrite?" in result.output
assert output_path.read_text() != "existing content"


Expand Down
Loading