executor: allow network providers #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tonistiigi
force-pushed
the
netproviders
branch
2 times, most recently
from
1f5a929 to
0f85581
Compare
AkihiroSuda
reviewed
Aug 4, 2018
| if err1 := pw.Close(); err == nil { | ||
| err = err1 | ||
| } | ||
| _ = err |
There was a problem hiding this comment.
Didn't notice this in original PR. Would you like a log in here. Don't think we can handle this error.
AkihiroSuda
reviewed
Aug 4, 2018
| @@ -65,6 +69,10 @@ func New(opt Opt) (executor.Executor, error) { | |||
|
|
|||
| root := opt.Root | |||
|
|
|||
| if err := setSubReaper(); err != nil { | |||
There was a problem hiding this comment.
is this specific to runcexecutor?
There was a problem hiding this comment.
This is needed for the new Wait() in runcexecutor to work properly.
AkihiroSuda
reviewed
Aug 4, 2018
| forwardIO.release() | ||
|
|
||
| defer func() { | ||
| go func() { |
There was a problem hiding this comment.
To return the result back to the solver faster. As this pr introduces new process invocations that were not needed before and therefore makes running a container slower.
tonistiigi
force-pushed
the
netproviders
branch
from
0f85581 to
3282631
Compare
Signed-off-by: Kunal Kushwaha <[email protected]> Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
netproviders
branch
from
3282631 to
f8dd602
Compare
|
@AkihiroSuda ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated out part of the work done by @kunalkushwaha in #309
This only adds the changes made to the executors and the new network provider interface so should be safe to merge. I will use this for bridge networking in moby integration similar way as the cni PR does.
@kunalkushwaha @AkihiroSuda