solver: net host with basic entitlements support #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Aug 7, 2018
cmd/buildctl/build.go
Outdated
| @@ -76,6 +77,10 @@ var buildCommand = cli.Command{ | |||
| Name: "secret", | |||
| Usage: "Secret value exposed to the build. Format id=secretname,src=filepath", | |||
| }, | |||
| cli.StringSliceFlag{ | |||
| Name: "allow", | |||
| Usage: "Allow extra privileged entitlement", | |||
There was a problem hiding this comment.
Allow extra privileged entitlement, e.g. network.host, security.unconfined?
AkihiroSuda
reviewed
Aug 7, 2018
client/client_test.go
Outdated
| defer c.Close() | ||
|
|
||
| st := llb.Image("busybox:latest"). | ||
| Run(llb.Shlex(`sh -c 'ping -c 1 8.8.8.8 2>&1 | grep "Network is unreachable"'`), llb.Network(llb.NetModeNone)) |
There was a problem hiding this comment.
wget https://example.com? (ping does not work for unprivileged users by default)
|
lint failure |
|
For my entitlements work, I took relevant code from Was stuck on how to pass the flags to buildkit worker, this PR will help me. |
tonistiigi
referenced
this pull request
Aug 7, 2018
Signed-off-by: Kunal Kushwaha <[email protected]>
tonistiigi
referenced
this pull request
Aug 7, 2018
Signed-off-by: Kunal Kushwaha <[email protected]>
tonistiigi
force-pushed
the
nethost
branch
3 times, most recently
from
555c8ff to
e62a6b0
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
AkihiroSuda
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds capabilities for configuring networking modes to support network=none in llb and
--net=host,--net=nonein Moby Dockerfiles.In order to implement it, I needed to do some basic preparation for entitlements. cc @kunalkushwaha PTAL . There are no entitlements in llb yet, nor any support for the
security.unconfined, nor daemon config but I created the base package to run the validation.network.hostis disabled atm globally https://github.com/moby/buildkit/pull/560/files#diff-d2a8a37b660c457a954dfeae935c476eR246. In the end, it could be configurable from daemon config but this is enough for Moby integration the enable it if needed.Based on #556