Skip to content

ci: compile header only tests in Debug mode#2870

Merged
zonca merged 1 commit into
scikit-hep:mainfrom
zonca:compile_debug
Dec 7, 2023
Merged

ci: compile header only tests in Debug mode#2870
zonca merged 1 commit into
scikit-hep:mainfrom
zonca:compile_debug

Conversation

@zonca

@zonca zonca commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

The header only tests were compiled in Release mode,
therefore making all assert statements ineffective.

See for example zonca#4
where I add an error in the unit test but tests pass anyway

@zonca zonca changed the title ci: compile in Debug mode ci: compile header only tests in Debug mode Dec 5, 2023
@zonca

zonca commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator Author

after this fix, the test where I added an error actually fails:
zonca#5

@zonca zonca self-assigned this Dec 5, 2023
@codecov

codecov Bot commented Dec 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2870 (3190cd6) into main (123fa09) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 77.88%.

Additional details and impacted files
Files Coverage Δ
src/awkward/contents/bitmaskedarray.py 70.81% <100.00%> (+1.53%) ⬆️
src/awkward/contents/bytemaskedarray.py 89.75% <100.00%> (+0.73%) ⬆️
src/awkward/contents/content.py 74.81% <100.00%> (-0.28%) ⬇️
src/awkward/contents/listoffsetarray.py 82.86% <100.00%> (+0.13%) ⬆️
src/awkward/contents/numpyarray.py 91.18% <100.00%> (ø)
src/awkward/contents/regulararray.py 87.43% <100.00%> (+0.18%) ⬆️
src/awkward/contents/unmaskedarray.py 74.60% <100.00%> (+0.39%) ⬆️
src/awkward/contents/listarray.py 91.78% <83.33%> (+1.06%) ⬆️
src/awkward/contents/unionarray.py 85.22% <75.00%> (-0.25%) ⬇️
src/awkward/contents/indexedarray.py 80.95% <82.35%> (+2.05%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

@ianna ianna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zonca - yes, indeed, the assertions are compiled out in a release build. Thanks for catching it!

@agoose77

agoose77 commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Thanks @zonca - this was a good oversight to catch!

@zonca
zonca merged commit a234407 into scikit-hep:main Dec 7, 2023
@zonca
zonca deleted the compile_debug branch December 7, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants