fix: fix ASAN detected buffer overflows in awkward-cpp#3898
Merged
Conversation
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3898 |
ianna
reviewed
Feb 28, 2026
ianna
reviewed
Mar 2, 2026
ianna
reviewed
Mar 11, 2026
Member
Author
|
CI is failing after the last commit |
Member
Author
|
I can check again with ASAN once you finish with your changes and it's back to working again. |
…) or masking a bug" This reverts commit b46825e.
ikrommyd
commented
Mar 11, 2026
Member
Author
|
@ianna are you happy with the changes now? |
ianna
approved these changes
Apr 30, 2026
ariostas
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected by running tests with an ASAN build of awkward-cpp