-
Notifications
You must be signed in to change notification settings - Fork 131
fix: fix ASAN detected buffer overflows in awkward-cpp #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
94d5c83
fix ASAN detected buffer overflows
ikrommyd 3dd5fec
raise error actually
ikrommyd fb65078
move check out of the loop and allow vectorization
ianna b46825e
the check is either redundant (guaranteed valid by the caller) or mas…
ianna e2f8889
Revert "the check is either redundant (guaranteed valid by the caller…
ikrommyd 83ad0c6
Merge branch 'main' into fix-buffer-overflows
ikrommyd 88cd568
add the last element index to the error
ikrommyd a2f6357
Revert "move check out of the loop and allow vectorization"
ikrommyd 1afcb1f
Merge branch 'main' into fix-buffer-overflows
ianna bd6f3c9
check only the last element
ikrommyd 4ee35fb
Merge branch 'main' into fix-buffer-overflows
ianna 0c72884
Merge branch 'main' into fix-buffer-overflows
ikrommyd b56c0ea
undo redundant check
ikrommyd c1563f5
Merge branch 'main' into fix-buffer-overflows
ikrommyd 67a7d71
Merge branch 'main' into fix-buffer-overflows
ianna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.