Skip to content

Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2024
Merged

Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies #291

merged 5 commits into from
May 10, 2024

Conversation

rpothin
Copy link
Contributor

@rpothin rpothin commented May 9, 2024

Related issue(s)

Overview of the changed files

  • Code
    • datasource_dlp_policy.go
    • resource_dlp_policy.go
  • Unit tests
    • datasource_dlp_policy_test.go
    • resource_dlp_policy_test.go

Validation

The latest execution of the Terraform Provider Checks workflow in my repository (fork) after the implementation of the changes in this pull request has been successful.

Note

Don't hesitate to ping me in the comment if you have questions or requests regarding this pull request.

Note

I am sorry, I did not take the time to implement brand new acceptance tests for the Power Platform DLP scope. I thought correcting this bug quickly was more important. It could definitely be part of future improvement work.

@mawasile
Copy link
Contributor

Thanks for contribution, looks ok. I will add the missing acceptance test

@mawasile mawasile added the bug Something isn't working label May 10, 2024
mattdot
mattdot approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mattdot mattdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpothin thanks for your contribution

@mattdot mattdot merged commit 0db25c3 into microsoft:main May 10, 2024
@rpothin
Copy link
Contributor Author

rpothin commented May 10, 2024

Hi team 👋🏼,

Thank you @mawasile and @mattdot for the review and the approval.

I am really interested in your work on this provider and I think I will try to contribute more in the future if you are open to this idea.

I already started a repository under my personal account to try to evangelize and showcase the provider to the Power Platform community: rpothin/PowerPlatform-Governance-With-Terraform

Have a great day.

@mawasile
Copy link
Contributor

Hi @rpothin

Your welcome to contribute. I've seen your repo and it looks interesting. If you will have any questions or blocker you can reach us via email/msteams over github or on @microsoft (our mail aliases are the same as our github user names, or firstname.lastname)

@mattdot
Copy link
Member

mattdot commented May 10, 2024

We are definitely open to it. Let us know what resources or data sources would help your use cases maybe we could start there.

We're interested to see where your governance work goes. Definitely a scenario that we want to enable with the provider.

We'll probably create a new release that includes your PR in a couple days once the data record pr also merges.

mawasile added a commit that referenced this pull request May 17, 2024
@mawasile
Squashed commit of the following:
0df7a7c 
commit 1b8c806
Author: mawasile <[email protected]>
Date:   Wed May 15 01:37:57 2024 +0200

    resource/datasource primary id should not changes on reapply (#292)

    * chore: making unique resource/datasource id stable & fixing unit tests

    * chore: fixing acceptance tests

    * chore: update display_name in powerplatform environment resources

    * adding new acceptance tests for dlp policies

    ---------

    Co-authored-by: Eduardo Sanchez <[email protected]>

commit 6142aaf
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 14 17:21:38 2024 -0600

    Bump hashicorp/local in /examples/resources/powerplatform_solution (#298)

    Bumps [hashicorp/local](https://github.com/hashicorp/terraform-provider-local) from 2.4.0 to 2.5.1.
    - [Release notes](https://github.com/hashicorp/terraform-provider-local/releases)
    - [Changelog](https://github.com/hashicorp/terraform-provider-local/blob/main/CHANGELOG.md)
    - [Commits](hashicorp/terraform-provider-local@v2.4.0...v2.5.1)

    ---
    updated-dependencies:
    - dependency-name: hashicorp/local
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 54a1173
Author: Matt Dotson <[email protected]>
Date:   Mon May 13 23:46:54 2024 -0700

    Addition of example directories for dependabot scanning (#296)

    * manual addition of example directories

    * fix duplicate path

commit b6b0eec
Author: Eduardo Sanchez <[email protected]>
Date:   Mon May 13 15:30:55 2024 -0600

    Updating Go version and modify tfproviderlint actions to use specified go version (#284)

    * Updating Go version.

    * Disable tfproviderlint.

    * Testing with go vet.

    * Changing run order.

    * Placing all runs inside one job.

    * testing with:         /usr/bin/tfproviderlint ./...

    * changing path for tfproviderlint.

    * testing setup go.

    * Show directory path.

    * Applying comments and updating version.

    * Updating devcontainer version.

    * Disabling tfproviderlint.

    ---------

    Co-authored-by: Eduardo Sanchez <[email protected]>
    Co-authored-by: mawasile <[email protected]>

commit 236a1bf
Author: mawasile <[email protected]>
Date:   Mon May 13 20:02:26 2024 +0200

    Updating developer guide with additional Information (#290)

    * chore: Update documentation for developer workflow and setup instructions

    * chore: Update developer documentation and add unit tests for new feature

    * update docs

    * chore: Update developer documentation, add unit tests, and regenerate docs

    * Update DEVELOPER.md

    Co-authored-by: Matt Dotson <[email protected]>

    ---------

    Co-authored-by: Matt Dotson <[email protected]>

commit ff470f7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 13 11:25:35 2024 -0600

    Bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#293)

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a)

    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit dce39d9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 13 11:25:04 2024 -0600

    Bump goreleaser/goreleaser-action in /.github/workflows (#294)

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a)

    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0db25c3
Author: Raphael Pothin <[email protected]>
Date:   Fri May 10 11:12:33 2024 -0400

    Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies (#291)
mawasile added a commit that referenced this pull request Aug 1, 2024
@mawasile
adding powerplatform_connection and powerplatform_connection_share (#377
abc20e0 
)

* wip

* Squashed commit of the following:

commit 1b8c806
Author: mawasile <[email protected]>
Date:   Wed May 15 01:37:57 2024 +0200

    resource/datasource primary id should not changes on reapply (#292)

    * chore: making unique resource/datasource id stable & fixing unit tests

    * chore: fixing acceptance tests

    * chore: update display_name in powerplatform environment resources

    * adding new acceptance tests for dlp policies

    ---------

    Co-authored-by: Eduardo Sanchez <[email protected]>

commit 6142aaf
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 14 17:21:38 2024 -0600

    Bump hashicorp/local in /examples/resources/powerplatform_solution (#298)

    Bumps [hashicorp/local](https://github.com/hashicorp/terraform-provider-local) from 2.4.0 to 2.5.1.
    - [Release notes](https://github.com/hashicorp/terraform-provider-local/releases)
    - [Changelog](https://github.com/hashicorp/terraform-provider-local/blob/main/CHANGELOG.md)
    - [Commits](hashicorp/terraform-provider-local@v2.4.0...v2.5.1)

    ---
    updated-dependencies:
    - dependency-name: hashicorp/local
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 54a1173
Author: Matt Dotson <[email protected]>
Date:   Mon May 13 23:46:54 2024 -0700

    Addition of example directories for dependabot scanning (#296)

    * manual addition of example directories

    * fix duplicate path

commit b6b0eec
Author: Eduardo Sanchez <[email protected]>
Date:   Mon May 13 15:30:55 2024 -0600

    Updating Go version and modify tfproviderlint actions to use specified go version (#284)

    * Updating Go version.

    * Disable tfproviderlint.

    * Testing with go vet.

    * Changing run order.

    * Placing all runs inside one job.

    * testing with:         /usr/bin/tfproviderlint ./...

    * changing path for tfproviderlint.

    * testing setup go.

    * Show directory path.

    * Applying comments and updating version.

    * Updating devcontainer version.

    * Disabling tfproviderlint.

    ---------

    Co-authored-by: Eduardo Sanchez <[email protected]>
    Co-authored-by: mawasile <[email protected]>

commit 236a1bf
Author: mawasile <[email protected]>
Date:   Mon May 13 20:02:26 2024 +0200

    Updating developer guide with additional Information (#290)

    * chore: Update documentation for developer workflow and setup instructions

    * chore: Update developer documentation and add unit tests for new feature

    * update docs

    * chore: Update developer documentation, add unit tests, and regenerate docs

    * Update DEVELOPER.md

    Co-authored-by: Matt Dotson <[email protected]>

    ---------

    Co-authored-by: Matt Dotson <[email protected]>

commit ff470f7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 13 11:25:35 2024 -0600

    Bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#293)

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a)

    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit dce39d9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 13 11:25:04 2024 -0600

    Bump goreleaser/goreleaser-action in /.github/workflows (#294)

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a)

    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0db25c3
Author: Raphael Pothin <[email protected]>
Date:   Fri May 10 11:12:33 2024 -0400

    Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies (#291)

* addind datasource_connections

* wip

* feat: Add GetConnectorDefinition method to ConnectionsClient

* wip

* ading basic functionality

* lint fix

* connection shares datsource

* feat: Add Azure OpenAI connection output

The code changes add a new output for the Azure OpenAI connection in the `powerplatform_connection` module. This output provides the description, value, and sensitivity of the connection.

* change to documentation

* adding TestAccConnectionssDataSource_Validate_Read

* adding tests

* adding test

* adding acceptance tests

* adding unit tests

* chore: Add connection shares data source

* removing unused method

* filename typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdot mattdot mattdot approved these changes

@mawasile mawasile mawasile approved these changes

@leighatami leighatami Awaiting requested review from leighatami

@ianjensenisme ianjensenisme Awaiting requested review from ianjensenisme

@polatengin polatengin Awaiting requested review from polatengin

@eduardodfmex eduardodfmex Awaiting requested review from eduardodfmex

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpothin @mawasile @mattdot