-
Notifications
You must be signed in to change notification settings - Fork 14
resource/datasource primary id should not changes on reapply #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eduardodfmex
merged 9 commits into
main
from
mawasile/287-powerplatform_environment_settings-id-changes-on-reapply
May 14, 2024
Merged
resource/datasource primary id should not changes on reapply #292
eduardodfmex
merged 9 commits into
main
from
mawasile/287-powerplatform_environment_settings-id-changes-on-reapply
May 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdot
previously approved these changes
May 9, 2024
…ngs-id-changes-on-reapply
…ngs-id-changes-on-reapply
mattdot
approved these changes
May 13, 2024
…ngs-id-changes-on-reapply
…ngs-id-changes-on-reapply
@mattdot should we remove ids on datasource as it looks like they are not necessary? |
eduardodfmex
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
…ngs-id-changes-on-reapply
mawasile
added a commit
that referenced
this pull request
May 17, 2024
commit 1b8c806 Author: mawasile <[email protected]> Date: Wed May 15 01:37:57 2024 +0200 resource/datasource primary id should not changes on reapply (#292) * chore: making unique resource/datasource id stable & fixing unit tests * chore: fixing acceptance tests * chore: update display_name in powerplatform environment resources * adding new acceptance tests for dlp policies --------- Co-authored-by: Eduardo Sanchez <[email protected]> commit 6142aaf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 14 17:21:38 2024 -0600 Bump hashicorp/local in /examples/resources/powerplatform_solution (#298) Bumps [hashicorp/local](https://github.com/hashicorp/terraform-provider-local) from 2.4.0 to 2.5.1. - [Release notes](https://github.com/hashicorp/terraform-provider-local/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-local/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-local@v2.4.0...v2.5.1) --- updated-dependencies: - dependency-name: hashicorp/local dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 54a1173 Author: Matt Dotson <[email protected]> Date: Mon May 13 23:46:54 2024 -0700 Addition of example directories for dependabot scanning (#296) * manual addition of example directories * fix duplicate path commit b6b0eec Author: Eduardo Sanchez <[email protected]> Date: Mon May 13 15:30:55 2024 -0600 Updating Go version and modify tfproviderlint actions to use specified go version (#284) * Updating Go version. * Disable tfproviderlint. * Testing with go vet. * Changing run order. * Placing all runs inside one job. * testing with: /usr/bin/tfproviderlint ./... * changing path for tfproviderlint. * testing setup go. * Show directory path. * Applying comments and updating version. * Updating devcontainer version. * Disabling tfproviderlint. --------- Co-authored-by: Eduardo Sanchez <[email protected]> Co-authored-by: mawasile <[email protected]> commit 236a1bf Author: mawasile <[email protected]> Date: Mon May 13 20:02:26 2024 +0200 Updating developer guide with additional Information (#290) * chore: Update documentation for developer workflow and setup instructions * chore: Update developer documentation and add unit tests for new feature * update docs * chore: Update developer documentation, add unit tests, and regenerate docs * Update DEVELOPER.md Co-authored-by: Matt Dotson <[email protected]> --------- Co-authored-by: Matt Dotson <[email protected]> commit ff470f7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:35 2024 -0600 Bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#293) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dce39d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:04 2024 -0600 Bump goreleaser/goreleaser-action in /.github/workflows (#294) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0db25c3 Author: Raphael Pothin <[email protected]> Date: Fri May 10 11:12:33 2024 -0400 Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies (#291)
mawasile
added a commit
that referenced
this pull request
Aug 1, 2024
) * wip * Squashed commit of the following: commit 1b8c806 Author: mawasile <[email protected]> Date: Wed May 15 01:37:57 2024 +0200 resource/datasource primary id should not changes on reapply (#292) * chore: making unique resource/datasource id stable & fixing unit tests * chore: fixing acceptance tests * chore: update display_name in powerplatform environment resources * adding new acceptance tests for dlp policies --------- Co-authored-by: Eduardo Sanchez <[email protected]> commit 6142aaf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 14 17:21:38 2024 -0600 Bump hashicorp/local in /examples/resources/powerplatform_solution (#298) Bumps [hashicorp/local](https://github.com/hashicorp/terraform-provider-local) from 2.4.0 to 2.5.1. - [Release notes](https://github.com/hashicorp/terraform-provider-local/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-local/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-local@v2.4.0...v2.5.1) --- updated-dependencies: - dependency-name: hashicorp/local dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 54a1173 Author: Matt Dotson <[email protected]> Date: Mon May 13 23:46:54 2024 -0700 Addition of example directories for dependabot scanning (#296) * manual addition of example directories * fix duplicate path commit b6b0eec Author: Eduardo Sanchez <[email protected]> Date: Mon May 13 15:30:55 2024 -0600 Updating Go version and modify tfproviderlint actions to use specified go version (#284) * Updating Go version. * Disable tfproviderlint. * Testing with go vet. * Changing run order. * Placing all runs inside one job. * testing with: /usr/bin/tfproviderlint ./... * changing path for tfproviderlint. * testing setup go. * Show directory path. * Applying comments and updating version. * Updating devcontainer version. * Disabling tfproviderlint. --------- Co-authored-by: Eduardo Sanchez <[email protected]> Co-authored-by: mawasile <[email protected]> commit 236a1bf Author: mawasile <[email protected]> Date: Mon May 13 20:02:26 2024 +0200 Updating developer guide with additional Information (#290) * chore: Update documentation for developer workflow and setup instructions * chore: Update developer documentation and add unit tests for new feature * update docs * chore: Update developer documentation, add unit tests, and regenerate docs * Update DEVELOPER.md Co-authored-by: Matt Dotson <[email protected]> --------- Co-authored-by: Matt Dotson <[email protected]> commit ff470f7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:35 2024 -0600 Bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#293) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dce39d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:04 2024 -0600 Bump goreleaser/goreleaser-action in /.github/workflows (#294) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0db25c3 Author: Raphael Pothin <[email protected]> Date: Fri May 10 11:12:33 2024 -0400 Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies (#291) * addind datasource_connections * wip * feat: Add GetConnectorDefinition method to ConnectionsClient * wip * ading basic functionality * lint fix * connection shares datsource * feat: Add Azure OpenAI connection output The code changes add a new output for the Azure OpenAI connection in the `powerplatform_connection` module. This output provides the description, value, and sensitivity of the connection. * change to documentation * adding TestAccConnectionssDataSource_Validate_Read * adding tests * adding test * adding acceptance tests * adding unit tests * chore: Add connection shares data source * removing unused method * filename typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes across several files, primarily focusing on the modification of the
id
attribute descriptions and the adjustment of test functions in the Power Platform data sources and resources. The changes also involve the removal and re-addition of a dependency in thego.mod
file.Changes to
id
attribute descriptions:id
attribute in the Read-Only section has been changed from various previous descriptions to "Id of the read operation". This change has been made in the following files:billing_policies.md
,data_loss_prevention_policies.md
,environment_powerapps.md
,environment_settings.md
,environments.md
,solutions.md
,tenant_settings.md
, andenvironment_settings.md
in thedocs/data-sources
directory andenvironment_settings.md
andtenant_settings.md
in thedocs/resources
directory. [1] [2] [3] [4] [5] [6] [7] [8] [9]Changes to test functions:
datasource_applications_test.go
,datasource_environment_application_packages_test.go
,datasource_securityroles_test.go
, anddatasource_tenant_settings_test.go
files in theinternal/powerplatform
directory, the test functions have been modified. Changes include the adjustment of thedisplay_name
attribute to use a helper function,TestName()
, and the modification of theid
attribute's regular expression in theTestMatchResourceAttr
function. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Changes to
go.mod
:github.com/google/uuid
dependency has been removed and then re-added as an indirect dependency. [1] [2]Addition of helper function:
TestName()
, has been added to themock_helpers.go
file in theinternal/powerplatform/mocks
directory. This function retrieves the name of the test function calling it.