adding powerplatform_connection and powerplatform_connection_share #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 1b8c806 Author: mawasile <[email protected]> Date: Wed May 15 01:37:57 2024 +0200 resource/datasource primary id should not changes on reapply (#292) * chore: making unique resource/datasource id stable & fixing unit tests * chore: fixing acceptance tests * chore: update display_name in powerplatform environment resources * adding new acceptance tests for dlp policies --------- Co-authored-by: Eduardo Sanchez <[email protected]> commit 6142aaf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 14 17:21:38 2024 -0600 Bump hashicorp/local in /examples/resources/powerplatform_solution (#298) Bumps [hashicorp/local](https://github.com/hashicorp/terraform-provider-local) from 2.4.0 to 2.5.1. - [Release notes](https://github.com/hashicorp/terraform-provider-local/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-local/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-local@v2.4.0...v2.5.1) --- updated-dependencies: - dependency-name: hashicorp/local dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 54a1173 Author: Matt Dotson <[email protected]> Date: Mon May 13 23:46:54 2024 -0700 Addition of example directories for dependabot scanning (#296) * manual addition of example directories * fix duplicate path commit b6b0eec Author: Eduardo Sanchez <[email protected]> Date: Mon May 13 15:30:55 2024 -0600 Updating Go version and modify tfproviderlint actions to use specified go version (#284) * Updating Go version. * Disable tfproviderlint. * Testing with go vet. * Changing run order. * Placing all runs inside one job. * testing with: /usr/bin/tfproviderlint ./... * changing path for tfproviderlint. * testing setup go. * Show directory path. * Applying comments and updating version. * Updating devcontainer version. * Disabling tfproviderlint. --------- Co-authored-by: Eduardo Sanchez <[email protected]> Co-authored-by: mawasile <[email protected]> commit 236a1bf Author: mawasile <[email protected]> Date: Mon May 13 20:02:26 2024 +0200 Updating developer guide with additional Information (#290) * chore: Update documentation for developer workflow and setup instructions * chore: Update developer documentation and add unit tests for new feature * update docs * chore: Update developer documentation, add unit tests, and regenerate docs * Update DEVELOPER.md Co-authored-by: Matt Dotson <[email protected]> --------- Co-authored-by: Matt Dotson <[email protected]> commit ff470f7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:35 2024 -0600 Bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#293) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dce39d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 13 11:25:04 2024 -0600 Bump goreleaser/goreleaser-action in /.github/workflows (#294) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@7ec5c2b...5742e2a) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0db25c3 Author: Raphael Pothin <[email protected]> Date: Fri May 10 11:12:33 2024 -0400 Fix proposition for the inversion between "Business" and "Non-business" connectors groups in Power Platform DLP policies (#291)
…-powerplatform_connection
…-powerplatform_connection
The code changes add a new output for the Azure OpenAI connection in the `powerplatform_connection` module. This output provides the description, value, and sensitivity of the connection.
10 tasks
mawasile
changed the title
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
eduardodfmex
previously approved these changes
Jul 30, 2024
examples/data-sources/powerplatform_connection_shares/outpuf.tf
Outdated
Show resolved
Hide resolved
ianjensenisme
requested changes
Jul 30, 2024
|
@mawasile I tried to test this locally and in a codespace, and got a mix of different errors in each place, probably related to configuration and Azure security. make test failed with symlink errors, which is probably a container problem. However I think I was able to successfully run the connections datasource example locally, and it looks like it missed the one OAI connection I have in the environment I was testing against. Let's block time to walk through what I'm trying and figure out whether I'm misguided or there's a real issue. |
…s://github.com/microsoft/terraform-provider-power-platform into mawasile/283-resource-powerplatform_connection
ianjensenisme
approved these changes
Jul 31, 2024
polatengin
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the Power Platform provider to add support for managing connections and connection shares. The changes include new data sources for fetching connection shares and connections, new resources for creating and managing connections and connection shares, and updates to the provider and testing code to support these new features. The changes are primarily focused on the
powerplatformpackage and its sub-packages.New Data Sources:
docs/data-sources/connection_shares.md: Added a new data source to fetch connection shares. This includes details on how to use the data source and its schema.docs/data-sources/connections.md: Added a new data source to fetch connections. This includes details on how to use the data source and its schema.New Resources:
docs/resources/connection.md: Added a new resource to create and manage connections. This includes details on how to use the resource and its schema.docs/resources/connection_share.md: Added a new resource to create and manage connection shares. This includes details on how to use the resource and its schema.Updates to Provider:
internal/powerplatform/provider.go: Updated the provider to include the new connection and connection share services.Updates to Testing Code:
internal/powerplatform/datasource_connections_test.go: Added a new test for the connections data source.Examples:
examples/data-sources/powerplatform_connection_shares/: Added an example of how to use the connection shares data source. [1] [2] [3]examples/data-sources/powerplatform_connections/: Added an example of how to use the connections data source. [1] [2]examples/resources/powerplatform_connection/: Added an example of how to use the connection resource. [1] [2]examples/resources/powerplatform_connection_share/: Added an example of how to use the connection share resource. [1] [2]Miscellaneous:
go.mod: Updated thegithub.lovev.site/google/uuidpackage to be a direct dependency.docs/resources/rest.md: Fixed some typos in the documentation.